feat: adds opensearchservice #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcooklin
force-pushed
the
fb/adds-opensearch
branch
from
91f3ef6
to
014adc7
Compare
|
Can you Check DCO Signing ? ;) |
Signed-off-by: Joel Cooklin <joel.cooklin@gmail.com>
jcooklin
force-pushed
the
fb/adds-opensearch
branch
from
014adc7
to
b8d295e
Compare
Signed-off-by: Joel Cooklin <joel.cooklin@gmail.com>
jcooklin
force-pushed
the
fb/adds-opensearch
branch
from
d599e63
to
a8e2129
Compare
chlunde
reviewed
Aug 30, 2022
|
cc @mvkrishna86 @sendmars - looks like all of you are interested in this, if you can, please coordinate. I think we have two PRs now. |
Signed-off-by: Joel Cooklin <joel.cooklin@gmail.com>
|
@jcooklin can you Check for merge conflicts? |
…nto fb/adds-opensearch
Signed-off-by: Joel Cooklin <joel.cooklin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds open search service
Fixes #1228
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Create/Delete have been tested successfully in us-west-2 using examples/opensearchservice/domain.yaml