fix(s3.bucket): Fixes #1165, discrepancy QueueConfiguration.Filter.Ke… #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroeder-paul
force-pushed
the
fix-aws-returning-Prefix-instead-of-prefix
branch
from
228e351
to
7164ded
Compare
…guration.Filter.Key.FilterRules.Name (with extensive corner case testing) Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul
force-pushed
the
fix-aws-returning-Prefix-instead-of-prefix
branch
from
7164ded
to
6d56d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The AWS API returns QueueConfiguration.Filter.Key.FilterRules.Name as "Prefix"/"Suffix" but expects "prefix"/"suffix", this leads to inconsistency and a constant diff.
Privious MR would panic if some or all of the keys (e.g. Key or Filter) are not there. This additon handles these cases. Additional tests for these cases were added.
Fixes #1165
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Test were added, see diff.