DBCluster auto generates password #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateus Miranda <mateusmiranda@gmail.com>
Signed-off-by: Mateus Miranda <mateusmiranda@gmail.com>
haarchri
approved these changes
Aug 11, 2022
This was referenced Aug 11, 2022
AlessandroBenoni
pushed a commit
to AlessandroBenoni/provider-aws
that referenced
this pull request
Aug 17, 2022
* RDS DBCluster autogenerates password when secret is empty Signed-off-by: Mateus Miranda <mateusmiranda@gmail.com> Signed-off-by: Alessandro Benoni <alessandro@bredec.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When a secret with the master password is not given, the resource will autogenerate an initial password
Fixes #667
Replaces #671 which seems to be stuck
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Compiled locally and tested in a sandbox cluster launching a few Aurora databases