Ensure masterUserPasswordSecretRef is still required #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Souza <101073+guilhermef@users.noreply.github.com>
2 tasks
haarchri
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guilherme Souza 101073+guilhermef@users.noreply.github.com
Description of your changes
When PR #1413 was tested, we noticed that the
masterUserPasswordSecretRefwas still required since it's used as a reference to the secret that will hold the generated DBCluster password.This PR will make it required again.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
A new DBCluster was created in our environment with an empty password.
The provider created a random password and stored it on the Secret.