Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support modify vpc peering options #1459

Merged

Conversation

zjj2wry
Copy link
Contributor

@zjj2wry zjj2wry commented Aug 30, 2022

Description of your changes

Fixes #1462

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: zhengjiajin <zhengjiajin@pingcap.com>
@zjj2wry zjj2wry force-pushed the support_modify_peering_options branch from d183ebc to 9dfb197 Compare August 30, 2022 07:15
@zjj2wry zjj2wry changed the title WIP: Support modify vpc peering options feat: support modify vpc peering options Aug 31, 2022
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested
Thanks for Implementation

@haarchri haarchri merged commit ffae9f2 into crossplane-contrib:master Sep 19, 2022
@r0mdau
Copy link
Contributor

r0mdau commented Sep 20, 2022

The CI lint is broken following this change

pkg/controller/ec2/vpcpeeringconnection/setup.go:84:1: cyclomatic complexity 11 of func `(*custom).postObserve` is high (> 10) (gocyclo)
func (e *custom) postObserve(_ context.Context, cr *svcapitypes.VPCPeeringConnection, obj *svcsdk.DescribeVpcPeeringConnectionsOutput, obs managed.ExternalObservation, err error) (managed.ExternalObservation, error) {
^
10:57:47 [FAIL]

@haarchri
Copy link
Member

@r0mdau thanks i had no time but it is on my list =) if you have time it would be great to see a PR - that helps a lot

@r0mdau r0mdau mentioned this pull request Sep 20, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support modify vpc peering options
3 participants