Remove masterUserPasswordSecretRef as a required attribute
#1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loalf
force-pushed
the
rds-dbcluster-required-attribute
branch
from
92e7130
to
52fc0e3
Compare
MisterMX
requested changes
Feb 22, 2023
loalf
force-pushed
the
rds-dbcluster-required-attribute
branch
from
52fc0e3
to
1bf7f80
Compare
MisterMX
requested changes
Feb 24, 2023
loalf
force-pushed
the
rds-dbcluster-required-attribute
branch
from
1bf7f80
to
2c659fa
Compare
|
@MisterMX thanks for guiding me in the right direction. I've updated the PR with the required changes (or so I think 😆 ). |
Signed-off-by: Javier Lopez <alcaraz1983@gmail.com>
loalf
force-pushed
the
rds-dbcluster-required-attribute
branch
from
2c659fa
to
90c8764
Compare
|
PR updated with a fully example on how to create a Global Cluster per requested. Pinging @MisterMX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1668
When creating an Aurora Global cluster with more than 2 regional clusters, the password attribute is mandatory for the first one, but not for the second one. Right now, it's impossible to create global cluster with more than 2 regional cluster.
If you avoid setting up the
masterUserPasswordSecretRef, Crossplane CRD will complain because this field is required and won't let you create the resource.If you set up the
masterUserPasswordSecretRef, the AWS API will complain that the cluster can't be created with the following error message