fix(rds): reset parameters removed from a parametergroup

[AlexLast]

Description of your changes

The existing update logic for DBClusterParameterGroup will only update parameters defined in spec.forProvider.parameters, if a parameter is removed it will no longer be managed.

This contribution ensures parameters removed from spec.forProvider.parameters will be reset to their default value. Assuming this approach is ok, I'll raise a similar PR for DBParameterGroup.

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

• Running a local build, testing existing and new functionality is working as expected

[AlexLast]

Looks like some changes have been made in this area in #1709, I'll rebase and refactor slightly.

[AlexLast]

@haarchri @MisterMX would you mind reviewing?

[MisterMX]

@AlexLast does this actually reset parameters that have been removed from the spec? There are changes in the update logic. Don't you have set the original values their as weel?

Also, can you implement the changes for DBParameterGroup as well?

[AlexLast]

@MisterMX I refactored slightly after the change to the update logic, I have rebased and manually tested, it is still working as expected. This will reset any parameters that are removed from spec, when using the ResetDBClusterParameterGroup call original values are not required. See - https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ResetDBClusterParameterGroup.html

Have updated PR to include the same logic for DBParameterGroup.

[AlexLast]

Hey @MisterMX @haarchri apologies to tag you again, would it be possible to review? Would ideally like to get this in before next release 🤞

[MisterMX]

Sorry, @AlexLast for the late response. Unfortunately, I couldn't make it in time for v0.39.

Howerver, this is looking good to me now. Thanks a lot!

[AlexLast]

No problem, thanks for the review 👍🏻