Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds/docdb)!: ParameterGroups remove ApplyMethod isUpToDate check #1709

Merged

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Mar 28, 2023

Description of your changes

RDS: DBParameterGroup, DBClusterParametergroup and DocDB DBClusterParametergroup

  • Breaking: switch to custom struct CustomParameters with only fields applyMethod, parameterName and parameterValue (terraform does it the same way)
  • Breaking: make parameter fields required in CRD (for RDS these 3 fields where already required by the controller before; for RDS and DocDB those fields were also already required indirectly by AWS )
  • reduce Parameter isUpToDate check to only consider parameterValue

Fixes #1708

Breaking changes ToDos/notes for users:

for resources RDS: DBParameterGroup, DBClusterParametergroup and DocDB DBClusterParametergroup claims need to be checked:

  • each entry in parameters no longer uses the previously read-only fields allowedValues, applyType, dataType, description, isModifiable, minimumEngineVersion, source and supportedEngineModes
  • each entry in parameters requires the only use of all 3 the fields applyMethod, parameterName and parameterValue

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually

Signed-off-by: Charel Baum <charel.baum-extern@deutschebahn.com>
@wotolom wotolom force-pushed the fix-parametergroups-applymethod branch from 4077633 to c84b190 Compare March 28, 2023 17:17
@wotolom wotolom changed the title fix(rds/docdb): ParameterGroups remove ApplyMethod isUpToDate check fix(rds/docdb)!: ParameterGroups remove ApplyMethod isUpToDate check Mar 28, 2023
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wotolom.

@haarchri can you take a second look at these changes?

@wotolom wotolom marked this pull request as ready for review March 30, 2023 12:32
@wotolom
Copy link
Contributor Author

wotolom commented Mar 30, 2023

Ready for review now as I got the confirmation from AWS support, that this is indeed the expected behavior for the field ApplyMethod.

@wotolom
Copy link
Contributor Author

wotolom commented Apr 5, 2023

@haarchri Considering the breaking changes, I added a potential ToDo note, that can be added to the release notes for users.

@haarchri
Copy link
Member

haarchri commented Apr 7, 2023

Sounds good to me - thanks

@haarchri haarchri merged commit 2f6449c into crossplane-contrib:master Apr 7, 2023
@wotolom wotolom deleted the fix-parametergroups-applymethod branch April 13, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rds/docdb: ParameterGroup in update loop bc of applyMethod
3 participants