Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam/policy): Treat single items as array #1774

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

MisterMX
Copy link
Collaborator

Description of your changes

Fixes the issue of single items in IAM policies. This treats:

action: "s3:PutObject"

as

action: ["s3:PutObject"]

Fixes #932
Replaces #942

Related to #1772

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Unit tests

@MisterMX MisterMX requested a review from haarchri June 14, 2023 14:46
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MisterMX MisterMX force-pushed the fix/issue-932 branch 2 times, most recently from f133eb6 to 5dd1d8b Compare June 16, 2023 11:14
@MisterMX MisterMX merged commit 6a78699 into crossplane-contrib:master Jun 16, 2023
8 checks passed
@MisterMX MisterMX deleted the fix/issue-932 branch October 19, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAMRole diff is to picky which results in unnecessary reconciling
2 participants