fix(hostedzone): fix DelegationSet.id can be nil panic #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlunde
reviewed
Sep 12, 2021
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
haarchri
force-pushed
the
delegation-hostedzone
branch
from
a8dbe59
to
8922d5c
Compare
chlunde
approved these changes
Sep 13, 2021
|
@chlunde is something missing for merging ? |
|
@haarchri I wanted to test it manually, since there's no test and I have not used hostedzone, but I think it's safe to merge, so I'll do it now 😄 |
6 tasks
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
…i-lint Inherit golangci-lint version from `build` submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christopher Haar chhaar30@googlemail.com
Description of your changes
obs.DelegationSet.Id status is nil for example for privateHostedZones - added check
Fixes #797
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
create hostedZone without error in provider-aws