Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Resource Access Manager (RAM) #838

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

haarchri
Copy link
Member

Description of your changes

Implements Resource Access Manager (RAM)

kubectl apply -f examples/ram/resourceshare.yaml
resourceshare.ram.aws.crossplane.io/sample-ram created
kubectl get resourceshare
NAME         READY   SYNCED   EXTERNAL-NAME
sample-ram   True    True     arn:aws:ram:eu-central-1:255932642927:resource-share/8b44b29d-6e51-44b0-9d30-0f9090400be1
kubectl describe resourceshare.ram.aws.crossplane.io/sample-ram
Name:         sample-ram
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-name: arn:aws:ram:eu-central-1:255932642927:resource-share/8b44b29d-6e51-44b0-9d30-0f9090400be1
API Version:  ram.aws.crossplane.io/v1alpha1
Kind:         ResourceShare
Metadata:
  Creation Timestamp:  2021-09-17T14:14:27Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:        1
  Resource Version:  3886223
  Self Link:         /apis/ram.aws.crossplane.io/v1alpha1/resourceshares/sample-ram
  UID:               ded717bd-9fac-41fe-b5cd-e878a354ab71
Spec:
  Deletion Policy:  Delete
  For Provider:
    Allow External Principals:  true
    Principals:
      123456789012
    Region:  eu-central-1
    Resource AR Ns:
      arn:aws:ec2:eu-central-1:255932642927:transit-gateway/tgw-0d8fdfe8c89fa6b2d
  Provider Config Ref:
    Name:  default
Status:
  At Provider:
  Conditions:
    Last Transition Time:  2021-09-17T14:14:27Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2021-09-17T14:14:27Z
    Reason:                Available
    Status:                True
    Type:                  Ready
Events:
  Type    Reason                   Age   From                                         Message
  ----    ------                   ----  ----                                         -------
  Normal  CreatedExternalResource  80s   managed/resourceshare.ram.aws.crossplane.io  Successfully requested creation of external resource

image

image

using as external-name the arn because in status deleted you can see resources have same naming
image

Fixes #603

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

created, deleted

@AaronME AaronME self-requested a review September 24, 2021 17:35
@AaronME AaronME self-assigned this Sep 24, 2021
@AaronME
Copy link
Collaborator

AaronME commented Dec 21, 2021

LGTM! @haarchri rebase to resolve conflicts and this is good to merge.

Thank you!

Signed-off-by: haarchri <chhaar30@googlemail.com>
Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@haarchri haarchri merged commit 5937a7d into crossplane-contrib:master Dec 21, 2021
@haarchri haarchri deleted the ram branch December 21, 2021 17:15
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…528e443b6f

Bump upjet to commit bd528e443b6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Access Manager (RAM) support
2 participants