-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Loadbalancer, Listener, and TargetGroup from elasticloadbalancingv2 #865
Conversation
@EdgeJ The code-generator now supports setting a different "model name" as part of the generator.yaml file : aws-controllers-k8s/community#985 - we need to bump to latest Code-generator |
@haarchri following the advice in that thread doesn't seem to be working for me. I updated the tag used for the code generator to
I'll keep debugging for now, but if you have any insight, it would help greatly. |
I discovered the issue. For the |
this is blocked by #920 |
88e0d33
to
6e98820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for contribution ;) i tested the resource examples - all are working creation/deletion- check my review - after that squash commits for clean history and we can merge the PR
Adds the Loadbalancer, Listener, and TargetGroup resources from the elbv2 api. Signed-off-by: EdgeJ <5093048+EdgeJ@users.noreply.github.com>
@haarchri I updated CRD field names, cleaned up the mistaken newline in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAME READY SYNCED EXTERNAL-NAME
targetgroup.elbv2.aws.crossplane.io/test-targetgroup True True arn:aws:elasticloadbalancing:us-east-1:255932642927:targetgroup/test-targetgroup/cbae8e0ba0ebb033
NAME READY SYNCED EXTERNAL-NAME
listener.elbv2.aws.crossplane.io/test-listener True True arn:aws:elasticloadbalancing:us-east-1:255932642927:listener/app/test-loadbalancer/d1441d261a57f64d/bce43527425177dc
listener.elbv2.aws.crossplane.io/test-listener-two True True arn:aws:elasticloadbalancing:us-east-1:255932642927:listener/app/test-loadbalancer/d1441d261a57f64d/9853d163a3de165f
NAME READY SYNCED EXTERNAL-NAME
loadbalancer.elbv2.aws.crossplane.io/test-loadbalancer True True arn:aws:elasticloadbalancing:us-east-1:255932642927:loadbalancer/app/test-loadbalancer/d1441d261a57f64d
issue fixed for listener error 400 in observer if loadbalancer is removed before listener;)
@EdgeJ LGTM thanks for contribution & extend/fixes code-generator
Signed-off-by: haarchri <chhaar30@googlemail.com>
aa512ea
to
4321ab5
Compare
Description of your changes
Implements 3 resource types from the
elasticloadbalancingv2
api group:Fixes #841
Fixes #699
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
There are 3 example yaml files to generate the new resources. The listeners.yaml file contains specifications to create 2 listeners and attach them to the same loadbalancer. Additionally, there are unit tests for the function used to generate
DefaultActions
types from the API that will work with the AWS SDK. This function was largely adapted from autogenerated code, but was needed in order to implement references within the API type.