Implement Loadbalancer, Listener, and TargetGroup from elasticloadbalancingv2

[EdgeJ]

Description of your changes

Implements 3 resource types from the elasticloadbalancingv2 api group:

• LoadBalancer
• Listener
• TargetGroup

Fixes #841
Fixes #699

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

There are 3 example yaml files to generate the new resources. The listeners.yaml file contains specifications to create 2 listeners and attach them to the same loadbalancer. Additionally, there are unit tests for the function used to generate DefaultActions types from the API that will work with the AWS SDK. This function was largely adapted from autogenerated code, but was needed in order to implement references within the API type.

[haarchri]

@EdgeJ The code-generator now supports setting a different "model name" as part of the generator.yaml file : aws-controllers-k8s/community#985 - we need to bump to latest Code-generator

[EdgeJ]

@haarchri following the advice in that thread doesn't seem to be working for me. I updated the tag used for the code generator to v0.15.2 (current latest) and added module_name: elasticloadbalancingv2 to generator-config.yaml. When attempting to generate the service, I get nil pointer errors:

➜ SERVICES=elasticloadbalancingv2 make services
HEAD is now at d2b0638 Update to ACK runtime `v0.15.2` (#234)
11:58:12 [ .. ] Generating elasticloadbalancingv2 controllers and CRDs
Error: template: /Users/jedge/git/crossplane/provider-aws/.work/code-generator/templates/crossplane/pkg/conversions.go.tpl:40:3: executing "/Users/jedge/git/crossplane/provider-aws/.work/code-generator/templates/crossplane/pkg/conversions.go.tpl" at <GoCodeSetUpdateInput .CRD "cr" "res" 1>: error calling GoCodeSetUpdateInput: runtime error: invalid memory address or nil pointer dereference
exit status 1
make: *** [services] Error 1

I'll keep debugging for now, but if you have any insight, it would help greatly.

[EdgeJ]

I discovered the issue. For the Listener objects in particular, generation is broken by ACK metadata. Adding a configuration line include_ack_metadata: false seems to fix the nil pointer issue. A bigger problem is that the crossplane command for the code-generator does not honor the model_name configuration parameter. I added a PR to the repo to hopefully amend this: aws-controllers-k8s/code-generator#237

[janwillies]

this is blocked by #920

[haarchri]

@EdgeJ we resolved #920 - did you have time to rebase and check again ?

[EdgeJ]

@EdgeJ we resolved #920 - did you have time to rebase and check again ?

Thanks @haarchri. Will take a look and build this with the latest code-generator.

[haarchri]

thanks for contribution ;) i tested the resource examples - all are working creation/deletion- check my review - after that squash commits for clean history and we can merge the PR

[EdgeJ]

@haarchri I updated CRD field names, cleaned up the mistaken newline in Makefile, and squashed down my commits. One caveat is that make reviewable seems to be failing on code generation for the sfn group, but this seems to be a regression of some sort in master and not related to these changes. Removing sfn from the GENERATED_SERVICES variable allows make reviewable to pass. False alarm, just a little housekeeping needed. Must've gotten some cruft in the .work directory on my local. Running rm -rf .work/* and git clean -fdx seemed to fix it.

[haarchri]

NAME                                                   READY   SYNCED   EXTERNAL-NAME
targetgroup.elbv2.aws.crossplane.io/test-targetgroup   True    True     arn:aws:elasticloadbalancing:us-east-1:255932642927:targetgroup/test-targetgroup/cbae8e0ba0ebb033

NAME                                                 READY   SYNCED   EXTERNAL-NAME
listener.elbv2.aws.crossplane.io/test-listener       True    True     arn:aws:elasticloadbalancing:us-east-1:255932642927:listener/app/test-loadbalancer/d1441d261a57f64d/bce43527425177dc
listener.elbv2.aws.crossplane.io/test-listener-two   True    True     arn:aws:elasticloadbalancing:us-east-1:255932642927:listener/app/test-loadbalancer/d1441d261a57f64d/9853d163a3de165f

NAME                                                     READY   SYNCED   EXTERNAL-NAME
loadbalancer.elbv2.aws.crossplane.io/test-loadbalancer   True    True     arn:aws:elasticloadbalancing:us-east-1:255932642927:loadbalancer/app/test-loadbalancer/d1441d261a57f64d

issue fixed for listener error 400 in observer if loadbalancer is removed before listener;)

@EdgeJ LGTM thanks for contribution & extend/fixes code-generator