dynamodb.table: implement update for global secondary indexes #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The diff and update methods aren't generated for that field since its name and type is different in
UpdateTableInput
fromCreateTableInput
. So, we had to manually implement the whole mechanism.Fixes a few small things like getting rid of cmpopts for
isUpToDate
and making sure we strip off the request ID from v1 SDK errors.Fixes #927
Note that it turned out
ReplicaUpdates
is only forGlobalTable
resource and it's already implemented.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manually with the example YAML by;