Ignore fields in glue.Crawler and lambda.Function that block code-generator bump
#992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itten code Signed-off-by: Muvaffak Onus <me@muvaf.com>
…dwritten code Signed-off-by: Muvaffak Onus <me@muvaf.com>
muvaf
commented
Dec 7, 2021
| if err != nil { | ||
| return managed.ExternalObservation{}, err | ||
| } | ||
| cr.SetConditions(xpv1.Available()) | ||
| return obs, nil | ||
| } | ||
|
|
||
| func postCreate(_ context.Context, cr *svcapitypes.Crawler, obj *svcsdk.CreateCrawlerOutput, _ managed.ExternalCreation, err error) (managed.ExternalCreation, error) { |
There was a problem hiding this comment.
External name feature implementation wasn't correct so I fixed that as well - we can never use cr.Name, the source of truth is always the annotation.
Signed-off-by: Muvaffak Onus <me@muvaf.com>
AaronME
approved these changes
Dec 7, 2021
|
Thanks, @muvaf ! |
2 tasks
This was referenced Dec 17, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Due to aws-controllers-k8s/community#1078 , we cannot use the code generated to set these fields. To unblock code-generator upgrade, we can ignore them so that their getter/setter logic is not generated and handwritten by us in
setup.goI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested