Update to latest ACK version to make the pipeline work again #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to make it work with Crossplane again Signed-off-by: Muvaffak Onus <me@muvaf.com>
Signed-off-by: Muvaffak Onus <me@muvaf.com>
negz
reviewed
Dec 8, 2021
| type S3OriginConfig struct { | ||
| OriginAccessIDentity *string `json:"originAccessIDentity,omitempty"` | ||
| OriginAccessIdentity *string `json:"originAccessIdentity,omitempty"` |
There was a problem hiding this comment.
This and the above will be breaking changes. It's an alpha API so we can do that, but it's probably worth a prominent release note at least.
| type ModifyVPNTunnelOptionsSpecification struct { | ||
| DPDTimeoutAction *string `json:"dPDTimeoutAction,omitempty"` | ||
| DPDTimeoutAction *string `json:"dpdTimeoutAction,omitempty"` |
There was a problem hiding this comment.
It seems like we don't generate the CRD that was supposed to use this struct, hence it doesn't show up in any CRDs.
| @@ -18,46 +18,6 @@ spec: | |||
| singular: address | |||
| scope: Cluster | |||
| versions: | |||
| - name: v1alpha1 | |||
There was a problem hiding this comment.
Did we expect these versions to disappear?
There was a problem hiding this comment.
@muvaf same question - in a few ec2 crds stuff is removed is this expected ? the rest in this PR looks good - tested also a few resources
There was a problem hiding this comment.
Yes, we added the skipversion tags to get those removed. See #876 for details.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
After a few fixes in code-generator that make the Crossplane integration work again (thanks @AaronME and @haarchri !) , #992 and a few fixes in the first commit of this PR, we are able to update code-generator to the latest version.
Note to reviewers, only the first commit contains handwritten changes.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make reviewable