Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume kube client package from provider-kubernetes & new identity modes for auth #223

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented May 24, 2024

Description of your changes

This PR consumes the exported kube client package in crossplane-contrib/provider-kubernetes#251, by dropping the duplicate implementation here. This also introduces support for authenticating with the following identities:

  • AzureWorkloadIdentityCredentials
  • UpboundToken

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

See the steps in, adapted for provider-helm crossplane-contrib/provider-kubernetes#251

go.mod Outdated Show resolved Hide resolved
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@lsviben
Copy link
Collaborator

lsviben commented May 28, 2024

Do we want to move that kube client package somewhere generic? Not saying now, but maybe some future step? Although not sure if there are other providers that would use it except helm/kubernetes, so maybe not worth it.

@turkenh turkenh marked this pull request as ready for review May 29, 2024 21:50
@turkenh
Copy link
Collaborator Author

turkenh commented May 29, 2024

Do we want to move that kube client package somewhere generic? Not saying now, but maybe some future step? Although not sure if there are other providers that would use it except helm/kubernetes, so maybe not worth it.

We have been duplicating the code here and there since we couldn't find a good home for this code till today. We could move it to crossplane-runtime but that would mean introducing dependencies like azure kubelogin or upbound-up-sdk etc.
What I am doing here is better than duplicating the code, which became hard to maintain as the number of auth methods increased while not being perfect. I am not aware of any other providers needing this, so probably already good enough for now.

Copy link
Collaborator

@lsviben lsviben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @turkenh

@turkenh turkenh merged commit bf29217 into crossplane-contrib:master Jun 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants