Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: switch to crossplane-system namespace everywhere for consistency #120

Merged
merged 4 commits into from May 24, 2023

Conversation

phisco
Copy link
Collaborator

@phisco phisco commented May 23, 2023

Description of your changes

Switching all occurrences of upbound-system namespace back to crossplane-namespace.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@bobh66
Copy link
Contributor

bobh66 commented May 23, 2023

crossplane-system is not created anymore,

Since when? Community crossplane deploys into crossplane-system, and that should remain the default for all non-Upbound providers.

upbound-system is only used for downstream uxp and should not be referenced in anything upstream of uxp

@turkenh
Copy link
Collaborator

turkenh commented May 23, 2023

Since when? Community crossplane deploys into crossplane-system, and that should remain the default for all non-Upbound providers.

upbound-system is only used for downstream uxp and should not be referenced in anything upstream of uxp

Agreed.

This was changed for local development recently for integrating uptest for e2e testing: #118

But, I believe we should rather configure uptest to use crossplane-system instead.

@phisco
Copy link
Collaborator Author

phisco commented May 23, 2023

good point @bobh66, totally agree, my main concern was about consistency and the procedure in the README properly working. I switched everything to crossplane-system and tomorrow we'll fix the build sub module to properly handle CROSSPLANE_NAMESPACE 👍

@phisco phisco marked this pull request as draft May 23, 2023 16:08
@bobh66
Copy link
Contributor

bobh66 commented May 23, 2023

Thanks @phisco !

…stency

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
@phisco phisco changed the title docs: switch to upbound-system namespace everywhere for consistency docs: switch to crossplane-system namespace everywhere for consistency May 24, 2023
@phisco phisco marked this pull request as ready for review May 24, 2023 06:55
Copy link
Collaborator

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phisco 🙌

@phisco
Copy link
Collaborator Author

phisco commented May 24, 2023

Just noticed the cleanup make local.down in the README doesn't work for me.
I'm not sure which would be the correct target to use for that though 🤔
CC @turkenh

@turkenh
Copy link
Collaborator

turkenh commented May 24, 2023

@phisco I assume it should be updated as make controlplane.down.

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
@phisco
Copy link
Collaborator Author

phisco commented May 24, 2023

pushed the change, it works fine now, totally missed that target, thanks @turkenh!

@turkenh turkenh merged commit d966cc7 into crossplane-contrib:main May 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants