New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: switch to crossplane-system namespace everywhere for consistency #120
Conversation
Since when? Community crossplane deploys into crossplane-system, and that should remain the default for all non-Upbound providers. upbound-system is only used for downstream uxp and should not be referenced in anything upstream of uxp |
Agreed. This was changed for local development recently for integrating uptest for e2e testing: #118 But, I believe we should rather configure uptest to use |
good point @bobh66, totally agree, my main concern was about consistency and the procedure in the README properly working. I switched everything to |
Thanks @phisco ! |
…stency Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @phisco 🙌
Just noticed the cleanup |
@phisco I assume it should be updated as |
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
pushed the change, it works fine now, totally missed that target, thanks @turkenh! |
Description of your changes
Switching all occurrences of
upbound-system
namespace back tocrossplane-namespace
.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested