Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom conn details #23

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Custom conn details #23

merged 1 commit into from
Jan 28, 2022

Conversation

schroeder-paul
Copy link
Contributor

@schroeder-paul schroeder-paul commented Jan 26, 2022 •
edited
Loading

Description of your changes

Implements the functionality described here: #6.

This includes:

  • Some refactoring
  • Add tests for new functionality
  • Add usage example

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

MisterMX
MisterMX requested changes Jan 27, 2022
View reviewed changes
pkg/controller/system/controller.go Outdated Show resolved Hide resolved
pkg/controller/system/controller.go Outdated Show resolved Hide resolved
pkg/controller/system/controller.go Outdated Show resolved Hide resolved
pkg/controller/system/controller.go Outdated Show resolved Hide resolved
pkg/controller/system/controller.go Outdated Show resolved Hide resolved
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 27, 2022
@schroeder-paul
refactor: honor review crossplane-contrib#23 (comment)
5ef86c8 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 27, 2022
@schroeder-paul
refactor: honor review crossplane-contrib#23 (comment)
fe098c5 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 27, 2022
@schroeder-paul
refactor: honor review crossplane-contrib#23 (comment)
36f52bf 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 27, 2022
@schroeder-paul
refactor: move logic to API
c38c94b 
honor review:
crossplane-contrib#23 (comment)
crossplane-contrib#23 (comment)

Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
@schroeder-paul schroeder-paul force-pushed the custom-conn-details branch 3 times, most recently from 6afa12f to 8fd401a Compare January 27, 2022 16:54
MisterMX
MisterMX requested changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @schroeder-paul . Some minor changes and I think we are ready to merge!

apis/system/v1alpha1/system.go Outdated Show resolved Hide resolved
apis/system/v1alpha1/system.go Outdated Show resolved Hide resolved
pkg/controller/system/controller.go Outdated Show resolved Hide resolved
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
fe96081 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
772617d 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
1559434 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
1c7168f 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
3f322dc 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
61578b0 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
1f686cf 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
fc731e1 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
34e0b77 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
d2c8dd3 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
e18720c 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul added a commit to schroeder-paul/provider-styra that referenced this pull request Jan 28, 2022
@schroeder-paul
honor review: crossplane-contrib#23 (comment)
543b418 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
@schroeder-paul
feat(system): Add support for custom/OPA system connection details
6e43eb7 
Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
@MisterMX MisterMX marked this pull request as ready for review January 28, 2022 15:14
MisterMX
MisterMX approved these changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot @schroeder-paul !

@MisterMX MisterMX merged commit 71b2160 into crossplane-contrib:main Jan 28, 2022
@schroeder-paul schroeder-paul deleted the custom-conn-details branch January 28, 2022 15:16
@MisterMX MisterMX mentioned this pull request Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schroeder-paul @MisterMX