refactor: honor review crossplane-contrib#23 (comment)

Signed-off-by: Paul Schroeder <97968850+schroeder-paul@users.noreply.github.com>
schroeder-paul · Jan 27, 2022 · 36f52bf · 36f52bf
1 parent fe098c5
commit 36f52bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pkg/controller/system/controller.go b/pkg/controller/system/controller.go
@@ -368,12 +368,11 @@ func (e *external) updateLabels(ctx context.Context, cr *v1alpha1.System) error
 }
 
 func getDetailsOfSystemType(systemType string) (systemDetails, error) {
-	desiredType := strings.ToLower(systemType)
 	err := errors.New(errSystemNotSupported)
 	var details systemDetails
 
 	switch {
-	case strings.HasPrefix(desiredType, "kubernetes"):
+	case strings.HasPrefix(systemType, "kubernetes"):
 		details.AssetType = "helm-values"
 		details.ConnectionDetailsValuesKey = "helmValues"
 		details.errGetValuesMessage = errGetHelmValues

diff --git a/pkg/controller/system/controller_test.go b/pkg/controller/system/controller_test.go
@@ -1444,7 +1444,7 @@ func TestGetDetailsOfSystemType(t *testing.T) {
 		},
 		"KubernetesSystem": {
 			args: args{
-				"kubERnETes:v123",
+				"kubernetes:v123",
 			},
 			want: want{
 				systemDetails{