Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-0.15] Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependencies #102

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[Release-0.15] Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependencies #102

merged 2 commits into from
Feb 22, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Feb 22, 2024

Description of your changes

In this PR:

  • Switch from the NoFork terminology to the TerraformPluginSDK terminology
  • Bump crossplane-runtime version to v1.15.1
  • Bump upjet version to v1.1.1

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Tested with uptest below

@turkenf
Switch from the NoFork terminology to the TerraformPluginSDK terminol…
adb7c14 
…ogy and bump dependiencies

Signed-off-by: Fatih Türken <turkenf@gmail.com>
(cherry picked from commit f17b9c0)
@turkenf turkenf changed the title Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependencies [Release-0.15] Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependencies Feb 22, 2024
@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024 •
edited

/test-examples="examples/applications/application.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8005214548

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024 •
edited

/test-examples="examples/conditionalaccess/accesspolicy.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8005218586

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024 •
edited

/test-examples="examples/groups/member.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8005221725

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024 •
edited

/test-examples="examples/serviceprincipals/principal.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8005226042

ulucinar
ulucinar approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm.
Let's also run at least one uptest again after these dependency changes.

go.mod Outdated
Comment on lines 142 to 151

replace golang.org/x/exp => golang.org/x/exp v0.0.0-20230713183714-613f0c0eb8a1

replace github.com/hashicorp/terraform-json => github.com/hashicorp/terraform-json v0.17.0

replace github.com/hashicorp/terraform-plugin-sdk/v2 => github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1

replace github.com/hashicorp/terraform-plugin-go => github.com/hashicorp/terraform-plugin-go v0.16.0

replace github.com/hashicorp/terraform-plugin-framework => github.com/hashicorp/terraform-plugin-framework v1.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the versions to the ones already defined in go.mod:

Suggested change
replace golang.org/x/exp => golang.org/x/exp v0.0.0-20230713183714-613f0c0eb8a1
replace github.com/hashicorp/terraform-json => github.com/hashicorp/terraform-json v0.17.0
replace github.com/hashicorp/terraform-plugin-sdk/v2 => github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1
replace github.com/hashicorp/terraform-plugin-go => github.com/hashicorp/terraform-plugin-go v0.16.0
replace github.com/hashicorp/terraform-plugin-framework => github.com/hashicorp/terraform-plugin-framework v1.2.0
replace golang.org/x/exp => golang.org/x/exp v0.0.0-20231006140011-7918f672742d
replace github.com/hashicorp/terraform-json => github.com/hashicorp/terraform-json v0.16.0
replace github.com/hashicorp/terraform-plugin-sdk/v2 => github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1
replace github.com/hashicorp/terraform-plugin-go => github.com/hashicorp/terraform-plugin-go v0.14.3

@sergenyalcin sergenyalcin mentioned this pull request Feb 22, 2024
Merged
1 task
@turkenf
go.mod fixes mentioned in the review comment
127b875 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024 •
edited

/test-examples="examples/serviceprincipals/principal.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8007189566

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024 •
edited

/test-examples="examples/groups/member.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8007201294

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024 •
edited

/test-examples="examples/applications/application.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8007204102

@turkenf turkenf merged commit 91d10ce into crossplane-contrib:release-0.15 Feb 22, 2024
12 checks passed
@turkenf turkenf deleted the release-0.41-bump-dependency branch February 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar ulucinar approved these changes

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turkenf @ulucinar