-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement portable classes #13
Conversation
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting on this! I like this emergent pattern of making a smaller change here in crossplane-runtime that we can then propagate to the other projects in smaller PRs.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready to merge; just a few minor comments to address.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Description of your changes
This PR is the first step in implementing the design proposed in crossplane/crossplane#743. It refactors the shared default class reconciler and claim reconciler. Updates will need to be applied to each of the provider stacks as well core crossplane.
This is a partial fix for crossplane/crossplane#703 and crossplane/crossplane#723.
The following changes will need to be applied following merge of this PR:
ClassKinds
instead of justClass
crossplane-runtime
dependency versionPolicy
kinds toClass
kinds and make sure they embedPortableClass
type and satisfyPortableClass
interfaceDefaultClassControllers
to passPortableClassKind
instead ofPolicyKind
Checklist
I have:
make reviewable
to ensure this PR is ready for review.clusterrole.yaml
to include any new types.