Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portable classes: implementation #786

Merged
merged 3 commits into from
Sep 12, 2019
Merged

portable classes: implementation #786

merged 3 commits into from
Sep 12, 2019

Conversation

hasheddan
Copy link
Member

@hasheddan hasheddan commented Sep 12, 2019 •
edited
Loading

Description of your changes

Implements portable classes following merge of crossplane/crossplane-runtime#13.

Ready to merge following #788!

Partially fixes #723 and #703

Checklist

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Ensured this PR contains a neat, self documenting set of commits.
  • Updated any relevant documentation, examples, or release notes.
  • Updated the RBAC permissions in clusterrole.yaml to include any new types.

@upbound-bot
Copy link
Collaborator

74% (+4.7%) vs master 69%

@hasheddan hasheddan mentioned this pull request Sep 12, 2019
Merged
4 tasks
negz
negz requested changes Sep 12, 2019
View reviewed changes
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This will be ready to merge when:

  • It's rebased after the AWS deletion work.
  • The CRUD related changes are in a separate commit.
  • We've addressed the potential panic in the SetPortableClassItems methods.

pkg/controller/workload/kubernetes/application/application.go Show resolved Hide resolved
apis/cache/v1alpha1/rediscluster_types.go Outdated Show resolved Hide resolved
@upbound-bot
Copy link
Collaborator

74% (+4.7%) vs master 69%

@hasheddan hasheddan mentioned this pull request Sep 12, 2019
Closed
@hasheddan hasheddan requested a review from negz September 12, 2019 22:11
@upbound-bot
Copy link
Collaborator

74% (+4.7%) vs master 69%

@negz negz changed the title portable classes: implementation DO NOT MERGE: portable classes: implementation Sep 12, 2019
@negz
Copy link
Member

negz commented Sep 12, 2019

Approved, but added a do not merge warning until the AWS stuff is sorted out. :)

@hasheddan
portable classes: implementation
c0be236 
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan
update utils following crossplane-runtime bump
2e9c643 
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan
SetPortableClassItems append
756a221 
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan changed the title DO NOT MERGE: portable classes: implementation portable classes: implementation Sep 12, 2019
@upbound-bot
Copy link
Collaborator

74% (-3.17%) vs master 77%

@negz negz merged commit a548946 into crossplane:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negz negz negz approved these changes

@jbw976 jbw976 Awaiting requested review from jbw976

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loose classRef matching for resource claims
3 participants
@hasheddan @upbound-bot @negz