apiextensions/claim: add context to claim Waiting condition

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
crossplane · Sep 8, 2023 · 601e91d · 601e91d
1 parent 63b1c99
commit 601e91d
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/internal/controller/apiextensions/claim/reconciler.go b/internal/controller/apiextensions/claim/reconciler.go
@@ -19,6 +19,7 @@ package claim
 
 import (
 	"context"
+	"fmt"
 	"time"
 
 	"github.com/google/go-cmp/cmp"
@@ -546,13 +547,18 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (reco
 
 	cm.SetConditions(xpv1.ReconcileSuccess())
 
-	if !resource.IsConditionTrue(cp.GetCondition(xpv1.TypeReady)) {
-		log.Debug("Composite resource is not yet ready")
-		record.Event(cm, event.Normal(reasonBind, "Composite resource is not yet ready"))
+	if cpReady := cp.GetCondition(xpv1.TypeReady); !resource.IsConditionTrue(cpReady) {
+		log.Debug("Composite resource is not yet ready", "reason", cpReady.Reason, "message", cpReady.Message)
+		if msg := cpReady.Message; msg != "" {
+			record.Event(cm, event.Normal(reasonBind, fmt.Sprintf("%s: %s", Waiting().Message, msg)))
+			cm.SetConditions(Waiting().WithMessage(fmt.Sprintf("%s: %s", Waiting().Message, msg)))
+		} else {
+			record.Event(cm, event.Normal(reasonBind, Waiting().Message))
+			cm.SetConditions(Waiting().WithMessage(Waiting().Message))
+		}
 
 		// We should be watching the composite resource and will have a
 		// request queued if it changes, so no need to requeue.
-		cm.SetConditions(Waiting())
 		return reconcile.Result{}, errors.Wrap(r.client.Status().Update(ctx, cm), errUpdateClaimStatus)
 	}