Skip to content

Commit

Permalink
Merge pull request #5034 from sttts/sttts-realtime-compositions-dont-…
Browse files Browse the repository at this point in the history
…block

apiextensions/definition: don't implicitly wait for MR informer, we do that ourselves
  • Loading branch information
negz committed Nov 20, 2023
2 parents cb15820 + c6a9bab commit f96a0b7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/controller/apiextensions/definition/composed.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func (i *composedResourceInformers) WatchComposedResources(gvks ...schema.GroupV

u := kunstructured.Unstructured{}
u.SetGroupVersionKind(gvk)
inf, err := ca.GetInformer(ctx, &u)
inf, err := ca.GetInformer(ctx, &u, cache.BlockUntilSynced(false)) // don't block. We wait in the go routine below.
if err != nil {
cancelFn()
log.Debug("failed getting informer", "error", err)
Expand Down

0 comments on commit f96a0b7

Please sign in to comment.