apiextensions/definition: don't implicitly wait for MR informer, we do that ourselves #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o that ourselves Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
phisco
approved these changes
Nov 17, 2023
negz
approved these changes
Nov 20, 2023
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
cache.GetInformerblocks by default, in a moment when we haven't wired the cancel function yet. We have custom logic to handle the wait for sync further down in theWatchComposedResourcesfunc. In contrast, our code handles the context with its cancel function correctly.This bug has potentially blocked the compositor before
, until the informer cleanup in.cleanupComposedResourceInformerskicked in after a minuteI have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.