Promote Lock to v1beta1 and mark v1alpha1 as deprecated
#2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a v1beta1 API for the Lock type and marks it as the storage version. The v1beta1 API is identical to the v1alpha1 API. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates the Lock CRD with v1beta1 schema, which is identical to v1alpha1. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds new Lock clientsets for interacting the the v1beta1 API version. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
The v1alpha1 Lock API has been deprecated in favor of the v1beta1 API and is scheduled for removal in Crossplane v1.7. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
|
Mostly LGTM, but I think we should also update the controller code to use the new |
|
@negz will do 👍🏻 |
Updates all Lock interactions in the revision controller to use the v1beta1 API. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates the package revision dependency resolver controller to use v1beta1 Lock types. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
commented
Aug 30, 2021
negz
approved these changes
Aug 30, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Introduces the
v1beta1LockAPI and marks thev1alpha1version as deprecated. Thev1alpha1version is scheduled to be removed in thev1.7Crossplane release.Fixes #2469
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested by installing Crossplane
v1.3.1, installingxp/getting-started-with-aws:v1.3.1, then upgrading to the build from this PR and verifying successful CRD install and no disruption of service.