fix(crds): add crd migration for locks.pkg.crossplane.io v1alpha1 #4447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
add crd migration for locks.pkg.crossplane.io v1alpha1
background:
If you installed Crossplane prior to version
v1.4.0
, you would have thev1alpha1
version oflocks.pkg.crossplane.io
. However, starting from versionv1.4.0
, the storageVersion was updated tov1beta1,
and drop forv1alpha1
was in versionv1.11.0
.1.4.0 - Lock to v1beta1 and mark v1alpha1 as deprecated
#2537
v1.11.0 - Lock API v1alpha1 has been dropped
#3479
Fixes #4442
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.create crossplane v1.3.2 -> upgrade to v1.7.0 -> upgrade to v1.12.2 (https://github.com/haarchri/crossplane-issue-4442)
and we can see the following issue:
crossplane: error: core.initCommand.Run(): cannot initialize core: cannot apply crd: cannot patch object: CustomResourceDefinition.apiextensions.k8s.io "locks.pkg.crossplane.io" is invalid: status.storedVersions[0]: Invalid value: "v1alpha1": must appear in spec.versions
we can see the following storedVersions:
hint: i tested also if migration from multiple crds is possible ;)
after this PR the result looks like: