Fix failure to pull private packages due to URI scheme #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to latest go-containerregistry including the k8schain and kubernetes auth submodules to fix the issue of not picking up matching pull secrets that use URI schemes. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Moves from using the LayerFromReader to LayerFromOpener as the former is now deprecated. The same beahvior is reflected, which we are okay with using in the context of unit tests. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
LayerFromReader is now deprecated, but we opt to keep the same functionality for the time-being, instead of moving to buffering through a temp file. TODO is added indicating that we can optimize this path in the future, but it is currently only used for building using the CLI. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
|
LGTM |
negz
approved these changes
Mar 4, 2022
|
Successfully created backport PR #2941 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes an issue with matching package pull secrets during registry authentication when auth data included a URI scheme (google/go-containerregistry#1299). Also, moves away from using the
LayerFromReaderfunction, which is now deprecated (due to issues with reading entire content into memory), but we opt to essentially replicate the previous behavior since we are currently only using it in tests and building packages with CLI (the latter of which we can optimize in the future, but have not here to keep the fix targeted).Fixes #2876
xref:
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Worked with @mcbenjemaa to verify that the issue with installing from artifact registry is now fixed, and also verified successful package install in my local environment.
Also validated that packages still build correctly with the
LayerFromOpenerchange: