Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerFromReader: buffer contents to a temp file instead of in memory #1285

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Feb 11, 2022

See https://twitter.com/ariadneconill/status/1491913976795602947

Also mark the method as Deprecated, and reimplement our own only usage of it in pkg/crane.Layer(filemap) using tarball.LayerFromOpener instead.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #1285 (5f2a418) into main (a44adc3) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1285      +/-   ##
==========================================
- Coverage   74.01%   73.99%   -0.03%     
==========================================
  Files         112      112              
  Lines        8374     8379       +5     
==========================================
+ Hits         6198     6200       +2     
- Misses       1573     1575       +2     
- Partials      603      604       +1     
Impacted Files Coverage Δ
pkg/v1/tarball/layer.go 68.71% <25.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44adc3...5f2a418. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants