Do not use version when indexing Used resources in Usage Handler #5353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes a bug in the Usage handler with multi versioned CRDs by dropping the usage of the
version
from the index string used by the handler.Example Scenario:
We define the following Usage resource:
For the following Object:
And we're running the latest provider kubernetes which has a
v1alpha2
as the storage version forObject
. So, when we get theObject
back after creation, we already see the version asv1alpha2
.Prior to this PR, deletion of the
ns-test-namespace
Object
is not blocked by the Usage since we were using the version in the indexer, sov1alpha1
Object
s blocked but notv1alpha2
s. With this PR, we will drop the version from the index, hence it will blockObjects
independent of versions.Related previous discussion: #4215 (comment)
make reviewable
to ensure this PR is ready for review.Added or updated e2e tests.backport release-x.y
labels to auto-backport this PR.Need help with this checklist? See the cheat sheet.