[Backport release-1.14] Do not use version when indexing Used resources in Usage Handler #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
force-pushed
the
backport-5353-to-release-1.14
branch
from
41fe556
to
25b6a09
Compare
Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit f3f5ece)
turkenh
force-pushed
the
backport-5353-to-release-1.14
branch
from
25b6a09
to
0cba65e
Compare
phisco
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Thanks @turkenh! note to the future, buf is failing due to the lack of branches support as per bufbuild/buf-push-action#34, which means we compare the 1.14 schema against the latest schema on main/release-1.15 which results in false breaking changes being reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5353 to
release-1.14.