This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Added tests for pulling private packages #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parul5sahoo
force-pushed
the
pvt_pkg_test
branch
2 times, most recently
from
9477486
to
3641e88
Compare
hasheddan
reviewed
Aug 13, 2022
There was a problem hiding this comment.
@parul5sahoo thanks for opening this! I know it is still a work in progress, but added some early comments to help guide any future work :)
parul5sahoo
force-pushed
the
pvt_pkg_test
branch
from
3641e88
to
1813e02
Compare
parul5sahoo
force-pushed
the
pvt_pkg_test
branch
2 times, most recently
from
b4ab9c8
to
8b24001
Compare
|
Updated the PR! @hasheddan and @jbw976 |
parul5sahoo
force-pushed
the
pvt_pkg_test
branch
4 times, most recently
from
61c6767
to
33e2a9a
Compare
hasheddan
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Two small nitpick, but otherwise LGTM -- thank you @parul5sahoo!
Signed-off-by: parul5sahoo <parulsahoo5jan@gamil.com>
parul5sahoo
force-pushed
the
pvt_pkg_test
branch
from
33e2a9a
to
ea40c05
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tests files for checking the process of pulling private packages from various registries supported by Crossplane.