Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): adopt ci workflow publish artifacts to avoid failed ci run in use/fork #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haarchri
Copy link
Contributor

@haarchri haarchri commented Jul 31, 2023

Description of your changes

skip ci workflow publish artifacts to avoid failed ci run in use as template or forks when UPBOUND_MARKETPLACE_PUSH_ROBOT_USR is not set in env
helps in forks to get ci green during development

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

…s without UPBOUND_MARKETPLACE_PUSH_ROBOT_USR env

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants