[Backport release-1.1] Add a new configuration option for required field generation #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com> (cherry picked from commit bdfbe67)
…iredFields - Deprecate config.MarkAsRequired in favor of a new configuration function on *config.Resource that still accepts a slice to mark multiple fields as required without doing and invervention in native field schema. Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com> (cherry picked from commit f25329f)
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com> (cherry picked from commit b73a85f)
sergenyalcin
changed the title
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com> (cherry picked from commit 845dbf6)
ulucinar
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. Changes already reviewed in #381.
Could you please have #381 also backported to the release-1.2 branch?
|
#383 Backport PR to rel-1.2 was opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #381 to
release-1.1.