-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make release event an opt-in feature #778
base: master
Are you sure you want to change the base?
Conversation
@lesleyrs you can potentially keep the pull requests open. Guess it might be cleaner anyways to have this explicit check for press events even if not enabling the feature introduced in this pr. |
Ok sounds good, I made it a mission to fix those libraries prior to this PR as the breakage was really quite bad for such a simple fix. But I'll try to get them merged still then. |
Event::Release
andEvent::Repeat
an opt in rather then default enabled feature on windows and kitty. The motivation is that it isn't fully cross-platform and causes developers confusion when receiving two events unexpectedly.Enter
release event at application start up.Fixes: #752