-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(examples): update input in examples to only use press events #129
Conversation
Closing this because it's being reverted crossterm-rs/crossterm#778 |
Any reason for the reopen ? |
This can actually be merged, crossterm-rs/crossterm#778 (comment). It's not 100% needed if crossterm puts release events behind a feature, but this will stop it from breaking whenever the feature is enabled on both windows and using kitty keyboard protocol on other platforms. At this moment all the modified examples aren't compatible with release events, and without this PR they don't work as intended because of "double" events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we don't know when they'll merge the PR putting this behind a feature in crossterm so makes sense to merge this for the time being !
Hi I saw the
user_input
example was already updated to work on windows but I just did the rest of them that use input other than quit.Also added a hack in panic.rs because on windows/powershell a release event is sent from when you originally press enter to
cargo run
. No more double presses now either.Fix #120
Edit: I just looked at the conventional commit thing and it's just a fix, you can merge this now