This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Rebase with chromium-crosswalk #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG=440560 TEST=Navigate in the omni box and observe appropriate caret movement. Note that this slightly deviates from the classic behavior where caret is also obtained from the node directly vi attributes in the single line case. TBR=dtseng@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/813743004 Cr-Commit-Position: refs/heads/master@{#311117} (cherry picked from commit 77e782b) Review URL: https://codereview.chromium.org/847293002 Cr-Commit-Position: refs/branch-heads/2272@{#5} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
Remove LOG(FATAL) from the path that is not actually fatal, but is valid on format enumeration. If a format is not suitable, we should just continue querying the hardware for more. TBR to prevent CFQ failures, as revert is now too complicated. TBR=rkc@chromium.org,scherkus@chromium.org BUG=None TEST=None Review URL: https://codereview.chromium.org/847273004 Cr-Commit-Position: refs/branch-heads/2272@{#6} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
////////////////////////////////////////////////////////////////////// Upstream CookiesFetcher No functional changes, yet. Review URL: https://codereview.chromium.org/832143009 Cr-Commit-Position: refs/heads/master@{#311199} ////////////////////////////////////////////////////////////////////// Delete Incognito profile cookies immediately after notification Immediately deletes the Incognito profile's cookies from the cookie jar as soon as Profile is notified that a profile has been deleted. The CookiesFetcher will confirm the incognito profile is missing, then schedule them for deletion. Also does general cleaning and renaming to less confusing method names. Review URL: https://codereview.chromium.org/833533004 Cr-Commit-Position: refs/heads/master@{#311393} ////////////////////////////////////////////////////////////////////// BUG=447267 TBR=tedchoc Review URL: https://codereview.chromium.org/852813002 Cr-Commit-Position: refs/branch-heads/2272@{#8} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
… background color is changed >Transparency of the background color affects the result of |Label::ComputeDrawStringFlags()|. > >BUG=447932 >R=sky >NOTRY=true > >Review URL: https://codereview.chromium.org/846853003 > >Cr-Commit-Position: refs/heads/master@{#311088} BUG=447932 TBR=sky Review URL: https://codereview.chromium.org/816223004 Cr-Commit-Position: refs/branch-heads/2272@{#9} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
This reverts commit a63c039. BUG=448829 R=knn@chromium.org Review URL: https://codereview.chromium.org/846413003 Cr-Commit-Position: refs/branch-heads/2272@{#10} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
BUG=chrome-os-partner:33558 Review URL: https://codereview.chromium.org/838863005 Cr-Commit-Position: refs/heads/master@{#311158} (cherry picked from commit b6535b1) Review URL: https://codereview.chromium.org/853773002 Cr-Commit-Position: refs/branch-heads/2272@{#11} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
BUG=443392 Review URL: https://codereview.chromium.org/809713006 Cr-Commit-Position: refs/heads/master@{#311359} (cherry picked from commit c9feaef) Review URL: https://codereview.chromium.org/830363004 Cr-Commit-Position: refs/branch-heads/2272@{#12} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
BUG=449013 TBR=newt@chromium.org Review URL: https://codereview.chromium.org/850913004 Cr-Commit-Position: refs/branch-heads/2272@{#14} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
BUG=405861 TEST=manually test on veyron_pinky with sandbox and make sure plugin is called successfully. Review URL: https://codereview.chromium.org/845253002 Cr-Commit-Position: refs/heads/master@{#311243} (cherry picked from commit 7dec42e) TBR=posciak@chromium.org,jorgelo@chromium.org Review URL: https://codereview.chromium.org/840373007 Cr-Commit-Position: refs/branch-heads/2272@{#15} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
Add a class for parsing VP8 streams as described in RFC 6386 and a simple unittest for it to media_unittests. TEST=media_unittests for Vp8Parser, VP8 HW decode and playback BUG=410152,chrome-os-partner:33728 Review URL: https://codereview.chromium.org/824563003 Cr-Commit-Position: refs/heads/master@{#311000} (cherry picked from commit 3e644c7) TBR=posciak@chromium.org,xhwang@chromium.org Review URL: https://codereview.chromium.org/848263002 Cr-Commit-Position: refs/branch-heads/2272@{#16} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
Per VDA/VEA API, it is not allowed to to post NotifyError until Initialize() returns successfully, as this may break clients depending on Initialize() to be synchronous. Also fix vdatest to not change state unless a decoder has been successfully initialized. BUG=chrome-os-partner:33728 TEST=vda/veatests Review URL: https://codereview.chromium.org/849533002 Cr-Commit-Position: refs/heads/master@{#311262} (cherry picked from commit d0fcae3) TBR=posciak@chromium.org Review URL: https://codereview.chromium.org/812093004 Cr-Commit-Position: refs/branch-heads/2272@{#17} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
Since we use the MPLANE API, we should consistently be passing *_MPLANE buffer types across all ioctl calls. Fix a typo in S_CROP call that used V4L2_BUF_TYPE_OUTPUT, instead of V4L2_BUF_TYPE_OUTPUT_MPLANE. BUG=chrome-os-partner:33728 TEST=veatest Review URL: https://codereview.chromium.org/848523002 Cr-Commit-Position: refs/heads/master@{#310964} (cherry picked from commit 7fd95e2) TBR=posciak@chromium.org Review URL: https://codereview.chromium.org/846453007 Cr-Commit-Position: refs/branch-heads/2272@{#18} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
Allow VP9 decode if HW/driver supports it. Instead of hardcoding supported formats, let the format setting logic query the device whether it supports the requested codec type. This has been reverted in bulk in https://codereview.chromium.org/809883004/, but was not the culprit. Please see https://codereview.chromium.org/845853005/ for details. Merging this for M41 because some CLs in 33728 modify the same place. TBR=owenlin@chromium.org,scherkus@chromium.org,rkc@chromium.org BUG=430638,chrome-os-partner:33728 TEST=video playback,vdaunittest Review URL: https://codereview.chromium.org/815443003 Cr-Commit-Position: refs/heads/master@{#310961} (cherry picked from commit d631ae2) TBR=posciak@chromium.org Review URL: https://codereview.chromium.org/838803004 Cr-Commit-Position: refs/branch-heads/2272@{#19} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
…ames construction into worker thread to fix crash problem. BUG=447415, 444121 Review URL: https://codereview.chromium.org/848833002 Cr-Commit-Position: refs/heads/master@{#311421} (cherry picked from commit a15f895) Review URL: https://codereview.chromium.org/848713003 Cr-Commit-Position: refs/branch-heads/2272@{#20} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
BUG=446610 TBR=mcasas TEST=Add log statement in function isLegacyDevice and navigate to any page in chrome that uses the camera to verify that Nexus 4 is INFO_SUPPORTED_HARDWARE_LEVEL_LEGACY and Nexus 5 is INFO_SUPPORTED_HARDWARE_LEVEL_FULL. Review URL: https://codereview.chromium.org/834423003 Cr-Commit-Position: refs/heads/master@{#311047} (cherry picked from commit f62e6ae) Review URL: https://codereview.chromium.org/830483006 Cr-Commit-Position: refs/branch-heads/2272@{#21} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
> BUG=448214 > > Review URL: https://codereview.chromium.org/847193003 > > Cr-Commit-Position: refs/heads/master@{#311410} > (cherry picked from commit 0ee19a5) TBR=juanlang@chromium.org Review URL: https://codereview.chromium.org/845403005 Cr-Commit-Position: refs/branch-heads/2272@{#22} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
The early out was accidentally dropped in a refactor. Add it back here. And also add unit tests for clear view. BUG=448488 Review URL: https://codereview.chromium.org/846323002 Cr-Commit-Position: refs/heads/master@{#311399} (cherry picked from commit 83cbc84) TBR=boliu@chromium.org Review URL: https://codereview.chromium.org/798763005 Cr-Commit-Position: refs/branch-heads/2272@{#23} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
> - Fix defaultControl to return ok button for error screen; > - Add aria-live and aria-atomic to content div so that it is read out > when the screen state is changed and all contents are updated; > > BUG=413766 > TEST=Test enable-debugging flow with ChromeVox and verify that title and message gets read on each step. > > Review URL: https://codereview.chromium.org/788953005 > > Cr-Commit-Position: refs/heads/master@{#311542} > (cherry picked from commit a63b2ff) TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/849103009 Cr-Commit-Position: refs/branch-heads/2272@{#25} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
TBR=michaeln BUG=449248 Review URL: https://codereview.chromium.org/840163002 Cr-Commit-Position: refs/heads/master@{#311078} (cherry picked from commit 996cd30) Review URL: https://codereview.chromium.org/849343002 Cr-Commit-Position: refs/branch-heads/2272@{#26} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
…UV420 format enumeration." This reverts commit 3936948. The reason is that we think this causes none working devices to be enumerated, see crbug/448599 original code review: https://codereview.chromium.org/802633006 BUG=441836,448599 TBR=mcasas,niklase@chromium.org Review URL: https://codereview.chromium.org/814573008 Cr-Commit-Position: refs/heads/master@{#311690} (cherry picked from commit c0b2e72) Review URL: https://codereview.chromium.org/814833010 Cr-Commit-Position: refs/branch-heads/2272@{#27} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
With the changes to make the Data Reduction Proxy a best effort proxy, AreDataReductionProxiesBypassed should take the Data Reduction Proxy config rather than use the request's proxy service config. BUG=448477 Review URL: https://codereview.chromium.org/848103002 Cr-Commit-Position: refs/heads/master@{#311580} (cherry picked from commit abc858d) Review URL: https://codereview.chromium.org/812263004 Cr-Commit-Position: refs/branch-heads/2272@{#28} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
Crash happens when releasing the audio resource of localusermedia in openSL ES. On Android there are two ways to get the audio input: openSL ES and java Recording API. We swtich to the Recording API as a workaround of the bug. The limitation is Recording API only be avaiable after version 15 of SDK. BUG=XWALK-1833
To support the feature of launch screen. Added a new listener FirstRenderedFrameListener. This listener will be triggered when the first visible content has been updated to the screen. SPEC: https://docs.google.com/a/intel.com/document/d/17PuNuHRTQuREUpaCvj-eEx7uYi2avd-VW-oaMXMpvwo/edit?pli=1# Design Doc: https://docs.google.com/a/intel.com/document/d/1YLajlZC7CkBOtEvzD6p6yeBr0HrPsaIGX8Eqhr3oTF4/edit#heading=h.mfsu3bk9566e Bug: XWALK-637 Reworked for M37
SSIA. We need it in order to be able to set ScreenOrientationProvider from Xwalk.
Unlike SurfaceView, TextureView can be moved, transformed and animated, but may consume a bit more memory resource. We need this since Crosswalk embedding API should have the capability of animating XWalkView in the embedder. See the discussion in chromium graphics-dev group https://groups.google.com/a/chromium.org/forum/#!topic/graphics-dev/Z0yE-PWQXc4 BUG=https://crosswalk-project.org/jira/browse/XWALK-1574 Reworked with M38
…aded for TextureView. Let's bail out after ContentReadbackHandler initialization in the case of TextureView. BUG=https://crosswalk-project.org/jira/browse/XWALK-1887 Reworked with M38.
Reason that add this change: 1080p video playback on Tizen is quite unsmooth on VTC-1010, with only 15 render fps and ~70% CPU usage. Ozone-wl landed a workaround solution that enables a zero buffer copy method that uses libva vaLockBuffer APIs which gains much better performance than previous method. intel/ozone-wayland#260 In order to make the change also benifit Crosswalk/Tizen, we should add the vaLockBuffer API declarations inside Chromium Crosswalk to compile the code successfully. The long term goal of our work would be landing those API declarations inside Chromium upstream, after the API implementations are landed in libva and libva-driver upstream. Therefore, this CL is a temporary solution. It would be reverted after the long term goal is achived.
This actually means that 'setShrinksViewportContentToFit' setting should be set. This is necessary for viewport meta tag enabling on Tizen.
Buffer swapping should not be synchronized so that the GPU process is not blocked by waiting for a frame update from Weston. BUG=TC-341 (This is oz-wl's 0008-Fix-crash-when-switching-to-console-VT-mode.patch.) It is not clear from ozone-wayland's pull request #300 if this change has been submitted upstream.
We started checking out this directory with Crosswalk PR#2426, but since we do not have it in .gitignore the directory ends up being removed every time we run gclient sync.
We started checking out this directory with Crosswalk including the webcl conformance test suite. So we should ignore this directory to avoid being removed when gclient sync.
Set an application ID and media class properties for the audio streams in pulseaudio and Murphy, so that the Murphy resource policy daemon can dictate when the audio will be paused and resumed in response to other audio playing. BUG=XWALK-2788
Fix GPU process crash on "Check failed: policy->PreSandboxHook()". BUG=XWALK-2789
This patch adds necessary API support in PlatformWindow. The changes need to be evaluated further before trying to upstream them. [This is oz-wl's 0009-PlatformWindow-Add-needed-support-in-PlatformWindow.patch.]
This patch set the resource set "name" property instead of "appid" as defined in the Murphy. BUG=TC-1731
This is highly experimental. Eventually, the goal is to only have platform specific parts in Wayland and core implementation as part of Chromium. Once, we have more matured implementation, initiate discussion upstream. (This patch is ozone-wayland's 0002-Remove-usage-of-DesktopFactory.patch).
This is temporary, so we can avoid gl circular dependency. Eventually, we want to be as aligned as possible with upstream Media solution and need to figure out how we could use upstream VaapiWrapper (while able to generate custom va_stubs if possible?). (This is oz-wl's 0005-Media-Build-VaapiPictureWayland-as-part-of-Media.patch).
This was causing problems when building chromium on Linux platforms with no x11 and Ozone enabled. https://codereview.chromium.org/817023005/diff/40001/content/common/BUILD.gn made changes so that we run the version in content_common with a va_stub_header.fragment always. Review URL: https://codereview.chromium.org/860163003 Cr-Commit-Position: refs/heads/master@{#312563} [This commit is required for building ozone-wayland on systems without X]
In r311421 a test was modified that called into XkbKeyboardLayoutEngine::ParseLayoutName but this function was not exposed in the header file. This change exposes this method in the header file and fixes the build. Original CL that introduced issue: https://codereview.chromium.org/848833002 BUG=None TEST=Compile of events_unittests completes Review URL: https://codereview.chromium.org/812613004 Cr-Commit-Position: refs/heads/master@{#311523}
Clang complains about un-used funtions on Linux builds. This CL fixes it. Review URL: https://codereview.chromium.org/841113004 Cr-Commit-Position: refs/heads/master@{#312121}
… file scheme. BUG=449075 TEST=content_unittests --gtest_filter=NavigationControllerTest.IsInPageNavigation Review URL: https://codereview.chromium.org/855883002 Cr-Commit-Position: refs/heads/master@{#313051} [This is related to XWALK-3344]
This script is only supposed to be used by Google's build slaves. However, the way it checks whether it is being run by a Google slave also works for our own build bots, but we do not have access to the Google Storage bucket where the files are. For now, disable the script to get our Android bots working again while we deal with this upstream.
This patch includes Chromium side changes that are needed for integrating WebMediaPlayer with the Murphy resource policy daemon.
…/common/gpu/media. This change followed by the virtual methods and override/final section of http://www.chromium.org/developers/coding-style/chromium-style-checker-errors. Only one of {virtual,override,final} should be used for each declaration, since override implies virtual. BUG=417463 Review URL: https://codereview.chromium.org/845673005 Cr-Commit-Position: refs/heads/master@{#312158}
Some change starting in M41 has started causing an existing bug in GetAndroidToolsStatusAndOutput() to fail in ICS devices. When the run_pie wrapper needs to be used, the call to `adb push' ends up overwriting the original command that was going to be run on the device, and the instrumentation tests fail like this: > LD_LIBRARY_PATH=/data/local/tmp/forwarder/ /data/local/tmp/run_pie push /path/in/host/out/Release/run_pie /data/local/tmp/run_pie; echo %$? [...] [PIE Loader] dlopen() failed: Cannot load library: load_library[1095]: Library 'push' not found. Fix it by using a different variable name for the `adb push' command that must be run on the host. BUG=373219 R=primiano@chromium.org, torne@chromium.org Review URL: https://codereview.chromium.org/926023002 Cr-Commit-Position: refs/heads/master@{#316233}
It is possible that another unzip is installed on a device and ends up being found first in $PATH. This can be problematic when binaries such as device_forwarder need to be re-uploaded, as other unzip implementations tend to loop forever asking whether the existing binary should be overwritten. Instead, put the path to our unzip implementation first so it is always used. BUG=428729, 433101 Review URL: https://codereview.chromium.org/926643003 Cr-Commit-Position: refs/heads/master@{#316402}
[Android] Backport some upstream commits to fix our device tests.
|
Testing patch series with axinging/chromium-crosswalk@d391344809adf7b4f39764ac0e15c378169b805f as its head.
|
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
…n Android. BUG=764061 TBR=melandory@chromium.org (cherry picked from commit c5d31f0) Change-Id: I4d775b4543112d38076c8e0927e9f8756f31c5fd Reviewed-on: https://chromium-review.googlesource.com/672523 Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502880} Reviewed-on: https://chromium-review.googlesource.com/677199 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#372} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase with chromium-crosswalk