-
Notifications
You must be signed in to change notification settings - Fork 212
Add GN build support for crosswalk-linux #375
Conversation
Testing patch series with heke123/chromium-crosswalk@d9f293d0faea58215f930ac00af500b059928bcb as its head.
|
The changes look fine to me, but they need to be committed differently: the |
And there's nothing Linux-specific here, so I'd retitle the PR and not mention Linux in the commit where you change the exec_script whitelist. |
One last thing: don't you also need to port our chromium-crosswalk changes to GN as well? The following commits touch gyp files:
Most of those are not related to Linux so you don't necessarily have to port all of them here, but I thought it'd be good to bring them up in case you were not considering them. |
@rakuco Thanks very much for remind me this. And below 2 commits will be port into GN soon. |
Yes, I think you'll need to port this one too (it should be a matter of adding a few lines to some BUILD.gn files). |
There doesn't seem to be anything to do with this one: as far as I can see, each target needs to set |
FYI, I'm handling the Android-specific changes in #377. |
@rakuco You intent to remove below 2 commits, I guess we don't need to port them either? |
Excellent!
Yep, correct. |
Testing patch series with heke123/chromium-crosswalk@ffc2b3214a333fda6e31f3a724bdd951ec265ba3 as its head.
|
Testing patch series with heke123/chromium-crosswalk@bde5610d5025d1ec94dee063eba78d8a6012d5e5 as its head.
|
Add "//xwalk/build/version.gni" the whitelist to make sure in src/xwalk it can execute "exec_script".
yes! victory at last 👍 |
Thanks so much for your help! |
When saving an icon in background, the sandbox may already be locked. This result in saving failure and an empty icon being used in extension. This CL 1. Avoid to save empty icon 2. If the widget meets an empty icon at some point, tries to show a default icon instead of a black one. Bug: 762517 Change-Id: I66c248f00524900e2c240acb94bc1ed4b5654d5f Reviewed-on: https://chromium-review.googlesource.com/663261 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501928}(cherry picked from commit 8c6dd42) Reviewed-on: https://chromium-review.googlesource.com/677363 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#375} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
As Chromium will deprecate GYP build system since M54, we need to enable
GN build support for Crosswalk as soon as possible.
Set xwalk as "extra_deps" to Chromium in xwalk/build/common.gni:
root_extra_deps = [ "//xwalk:xwalk_builder" ]