This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
M53: Fix GYP for Android. #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you submitted a patch upstream for this? Otherwise, I don't think we can land these patches just to make Android build work on gyp. We will have to wait until GN build is working on Android. |
|
I think it was more of an experiment to see how much the gyp files would need to be changed in case the GN code wasn't ready soon. |
|
Yes, true. At first, I thought I'm able to build the Android build completely, but then it turned out more fixes are needed. I guess we can discard this PR. |
This is a change that should be squashed into "[Temp] Make |enable_webvr==0| work", and just adds the required changes to the GN build so that it is aware of the fact that CardboardVRDevice.java resides in another directory. BUG=XWALK-6746
In the future, this change should be squashed into "[Android] Change the API for ApplicationStatus in base dir". This patch adds the newly-introduced ApplicationStatusManager.java to base/BUILD.gn (in GN all files must be listed explicitly).
> This effectively makes it a configurable argument that can be changed by > downstreams and users alike; so far, trying to change it via `gn args' > failed with: > > The variable "enable_webvr" was set as a build argument > but never appeared in a declare_args() block in any buildfile. > > BUG=389343 > R=bajones@chromium.org,brettw@chromium.org,dpranke@chromium.org > > Review-Url: https://codereview.chromium.org/2198003002
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Bug: 755620 Change-Id: Id22d2b9b986494328f7dcf93d06771118e44289c Reviewed-on: https://chromium-review.googlesource.com/671007 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502813}(cherry picked from commit 435a341) Reviewed-on: https://chromium-review.googlesource.com/677324 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#376} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It partly works. At least, gyp_xwalk can be executed and almost half of the source code files can be compiled.