This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
next: Rebase patch controlling the WebVR build #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
referenced
this pull request
Sep 1, 2016
This is a change that should be squashed into "[Temp] Make |enable_webvr==0| work", and just adds the required changes to the GN build so that it is aware of the fact that CardboardVRDevice.java resides in another directory. BUG=XWALK-6746
|
@rakuco I have removed the commit so you don't need to revert it now but make sure to rebase your PR. |
|
I'm no longer at work today, so I'll only be able to do that tomorrow. You can also just cherry-pick the patch if you prefer. |
This is a backport of some of the build system bits of http://crrev.com/2219203002 ("Migrate WebVR Cardboard implementation to GVR"): we are not interested in the "move to GVR" part, but this change also makes the dependency on some devices/vr targets optional based on the value of `enable_webvr`, which is something we want in order to be able to build Crosswalk with that flag off. This commit will not be necessary once we move to M54 and incorporate the CL mentioned above. BUG=XWALK-6746
rakuco
force-pushed
the
enable_webvr-m53
branch
from
6dff43e
to
12388eb
Compare
rakuco
changed the title
|
rebased, merging. |
|
I'll take care of rolling DEPS.xwalk. |
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
If device list iteration was not finished during HandleInitialize, observers would never be registered. TBR=jdufault@google.com (cherry picked from commit 59e6569) Bug: 766781 Change-Id: Iecbcb83e48816142cb37d6db560841515d700b60 Reviewed-on: https://chromium-review.googlesource.com/675579 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503254} Reviewed-on: https://chromium-review.googlesource.com/677471 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#383} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set first reverts "[Temp] Make |enable_webvr==false| work in GN" (see my comment in accdb96) and later implements the same thing in the right files.
You can get rid of both the first commit and accdb96, as only "[Temp] Only depend on deviecs/vr when enable_webvr is on" is required in M53.