code clean and optimize

[yetist]

Maybe we should clean up and optimize the code if have enough time? I found those code should be cleaned up:

1. #if 0 ...... #endif
2. The commented or invalided code.
3. Deprecations api migrate, like gconf to gsettings, dbus-glib to gdbus, etc.
4. Use gresource to include resource files, like images, ui files, etc.
5. Rewrite real object to instead alias or macro defined object under src/xiphos_html.
6. Eliminate global and external variables, decouple code, and avoid the internal implementation of exposed objects.
7. The address of the license is located in the header of some files.

[karlkleinpaste]

particularly for the "#if 0" case, that has at times been a habit of mine, to remove something from current use but keep it present (and visible, especially, so it's not forgotten) in case it needs to be brought back into use later. i recall using that a number of times some years ago, when doing a round of cleanups consequent to cppcheck analysis -- quite a few unused functions were kept within #if 0 blocks because i wasn't sure actual removal was a good idea. perhaps it's time to make them go away.

but otherwise, yes, it seems there is always a great deal of clean-up opportunity available. there is a lot of quite old code -- old elements of the settings structure, no longer used, for example. what was previously called gnomesword started in 2000, using gtk1, and dead artifacts from almost 2 decades ago remain.

[stappersg]

About the deprecated 'dbus-glib',

That is about item 3, Deprecations api migrate, like gconf to gsettings, dbus-glib to gdbus, etc. from the opening of this issue.

Did it happen or did we learn that it is not wise to report several issues in a single issue?

[teusbenschop]

I opened a new issue for migrating away from dbus-glib:

#1049