Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for SWR 1.0.x #160

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Update for SWR 1.0.x #160

merged 2 commits into from
Nov 8, 2021

Conversation

eitoball
Copy link
Collaborator

@eitoball eitoball commented Oct 30, 2021

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR changes dependency of SWR to version 1.0.0 or above.

  • What is the current behavior? (You can also link to an open issue here)

Generated code with version 0.5.6 won't work with SWR 1.0.x.

  • What is the new behavior (if this is a feature change)?

Generated code will work with with SWR 1.0.x.

  • Other information:

It seems that prettier didn't like format of src/index.ts, so the file has been updated with prettier --change

@eitoball
Copy link
Collaborator Author

eitoball commented Nov 6, 2021

@croutonn I would appreciate if you take a look at this PR. If you are busy, I can help you to maintain this repository.

@croutonn
Copy link
Owner

croutonn commented Nov 6, 2021

@eitoball こんばんは。このライブラリは実験的に作ってみたものの、自分で使うケースがほぼ無くてモチベーションが保てないでいるので、メンテナンス助けていただけるのならすごくありがたいです!

@croutonn croutonn merged commit eea8792 into croutonn:main Nov 8, 2021
@eitoball
Copy link
Collaborator Author

eitoball commented Nov 8, 2021

@croutonn レビュー、そして、マージありがとうございます。管理についてですが、このレポジトリのadmin権限と、npmjs.comでパッケージの方で、eitoball を collaborator にして頂けると助かります。

@croutonn
Copy link
Owner

croutonn commented Nov 9, 2021

@eitoball 今しがた権限付与申請出しました。よろしくお願いいたします。

@eitoball
Copy link
Collaborator Author

eitoball commented Nov 9, 2021

@croutonn ありがとうございます。renovate の PR をマージして、0.7.0 をリリースしていきたいと思います。Thank you. I will release 0.7.0 after merging all PRs by renovate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants