network: set max mtu of a parent to the max of its children #1371
Conversation
There was a problem hiding this comment.
There is still @vuntz comment regarding a possible optimization: #1228 (comment)
But, I'd suggest to address that in a follow up PR to get this one finally merged.
|
@nicolasbock could you re-review? I had to correct a rebase error since your first review |
|
|
||
| unless all_children.empty? | ||
| max_mtu_nic = all_children.max_by { |k, v| v["mtu"] }[0] | ||
| ifs[nic.parent]["mtu"] = ifs[max_mtu_nic]["mtu"] |
There was a problem hiding this comment.
There was some .to_i in the initial PR. It's not strictly required, I guess, though.
There was a problem hiding this comment.
Hmm, you're right that it was there. I removed it because it there before the change and because it's an assignment, not a comparison, so it doesn't matter that much. I'll add it back though.
Ha, you got me |
iterate over all the children to obtain the max mtu that we need to set to a parent nic. Before this, only the first vlan children of a parent was used to set an mtu value, failing afterwards if the next vlan had a bigger value.
Navin found during testing that some configurations could lead to the var all_children being empty and that would break the chef run. This introduces a guard against that.
🤣 |
What about the missing uppercase? ;-) |
(originally at #1228, description copied)
iterate over all the children to obtain the max mtu that we need to
set to a parent nic. Before this, only the first vlan children of a parent
was used to set an mtu value, failing afterwards if the next vlan had a bigger
value.
Introduced in #1084