Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manila: Fixup deprecated options (SCRD-6084) #1969

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Jan 8, 2019

The api_insecure option in the [nova], [neutron], and [cinder] groups
was replaced by just insecure[1].

[1] https://docs.openstack.org/releasenotes/manila/rocky.html

@cmurphy cmurphy requested a review from toabctl as a code owner January 8, 2019 11:47
toabctl
toabctl previously approved these changes Jan 8, 2019
nicolasbock
nicolasbock previously approved these changes Jan 8, 2019
The `api_insecure` option in the [nova], [neutron], and [cinder] groups
was replaced by just `insecure`[1]. We were already setting `insecure`
so just removed the unused option.

[1] https://docs.openstack.org/releasenotes/manila/rocky.html
@cmurphy
Copy link
Contributor Author

cmurphy commented Jan 9, 2019

We were already setting insecure, removed the duplicated option now.

Copy link
Contributor

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better now 😄

@cmurphy cmurphy merged commit 7a70262 into crowbar:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants