This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Temp TheaterMode button fix & making Tmode more immersive for the new Mixer UI #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New Top bar is removed * New bar under stream that contains -- Viewer Count -- Follow and Sub button -- Game name will now be hidden when theatermode is activated
small code cleanup
Top bar goes poof Bottom bar goes poof Issues: Chat appears cut off at the top when theater mode is on.
This reverts commit 7b3e1d3.
1) When theatermode enabled
* chat will once again have an unappealing top bar that comes with anniversary design nav bar at the top. Hiding this with my current method will break chat box when theater mode is turned off.
2) cleaned/cleared up my comments, and removed initial test pushes to fork
3) automatically turning on theatermode removed, see mixrelixr.js line 456's removal.
* if you wanted to test out w/o editing code, load the unpacked extension to chrome, go to a stream, change options "separate chat lines or alternating background chat colors" either on or off. Then the theater button will appear for that session.
--2.5 second delay added to adding theater mode button. This is a temporary fix, and usually works while waiting for the player controls to fully load. Refresh still needed if the delay doesn't work
|
This looks great, thanks for digging into this and getting it working @FierySama! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
https://streamable.com/ehnpn <-- short demonstration of fix and update
Alternate Designs
Benefits
The button works again even as a temp fix, plus things might be more immersive depending on the person!
Possible Drawbacks
It will probably break if any of the new Mixer ui is renamed, changed, or moved around.
Applicable Issues