Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend try/finally block to work with awaitable finalizers #4

Closed
wants to merge 1 commit into from

Conversation

Horusiath
Copy link

This is my first PR, so some help will be needed eg. how do you test this?

@NinoFloris
Copy link
Member

Ha, this grew from a little research project to something that's seriously used a bit too quickly.
Robert (from TaskBuilder.fs) has given permission to use their tests though!

Does this PR actually allow something like the following to compile?

let foo = task {
    try 
      return ()
    finally
      let! x = Task.Yield()
}

@Horusiath
Copy link
Author

It looks like it doesn't work that way - F# compiler lags behind.

@NinoFloris
Copy link
Member

Nothing to merge here then :/

@Horusiath Horusiath closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants