Added stringId as param in string comments (#54)

crowdin · Oct 23, 2022 · d25f098 · d25f098
1 parent 1951497
commit d25f098
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/crowdin_api/api_resources/string_comments/resource.py b/crowdin_api/api_resources/string_comments/resource.py
@@ -61,6 +61,7 @@ def add_string_comment(
         self,
         projectId: int,
         text: str,
+        stringId: int,
         targetLanguageId: str,
         type: StringCommentType,
         issueType: Optional[StringCommentIssueType] = None,
@@ -77,6 +78,7 @@ def add_string_comment(
             path=self.get_string_comments_path(projectId=projectId),
             request_data={
                 "text": text,
+                "stringId": stringId,
                 "targetLanguageId": targetLanguageId,
                 "type": type,
                 "issueType": issueType,

diff --git a/crowdin_api/api_resources/string_comments/tests/test_string_comments_resources.py b/crowdin_api/api_resources/string_comments/tests/test_string_comments_resources.py
@@ -84,11 +84,13 @@ def test_list_string_comments(self, m_request, in_params, request_params, base_a
             (
                 {
                     "text": "text",
+                    "stringId": 1,
                     "targetLanguageId": "ua",
                     "type": StringCommentType.COMMENT,
                 },
                 {
                     "text": "text",
+                    "stringId": 1,
                     "targetLanguageId": "ua",
                     "type": StringCommentType.COMMENT,
                     "issueType": None,
@@ -97,12 +99,14 @@ def test_list_string_comments(self, m_request, in_params, request_params, base_a
             (
                 {
                     "text": "text",
+                    "stringId": 1,
                     "targetLanguageId": "ua",
                     "type": StringCommentType.COMMENT,
                     "issueType": StringCommentIssueType.CONTEXT_REQUEST,
                 },
                 {
                     "text": "text",
+                    "stringId": 1,
                     "targetLanguageId": "ua",
                     "type": StringCommentType.COMMENT,
                     "issueType": StringCommentIssueType.CONTEXT_REQUEST,