Fix/search by language code and expose manifest timestamp #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevheniyJ
requested changes
Jan 22, 2021
|
@yevheniyJ thanks for the quick feedback. I incorporated the requested changes, let me know if they are okay. Cheers |
|
I will release new version with these changes later on today. |
|
@joelfsreis v0.1.1 is now available and contains these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose Manifest timestamp.
Search by language code.
listLanguages()I have the English language asen-GBanden-US. With current implementation is only possible to get the default English translation (with the twoLetterCode = 'en')getTranslations()it fails because does not find a match for the different English languages.