-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/search by language code and expose manifest timestamp #10
Fix/search by language code and expose manifest timestamp #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I left few minor comments which are mainly related to missing unit tests. Please let me know if you will struggle with fixing them.
@yevheniyJ thanks for the quick feedback. I incorporated the requested changes, let me know if they are okay. Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I will release new version with these changes later on today. |
@joelfsreis v0.1.1 is now available and contains these changes |
Expose Manifest timestamp.
Search by language code.
listLanguages()
I have the English language asen-GB
anden-US
. With current implementation is only possible to get the default English translation (with the twoLetterCode = 'en')getTranslations()
it fails because does not find a match for the different English languages.