feature: search based on multiple models and fields #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nice idea!. Thank you for sharing it. Let us analyze whether to add it or adapt it. |
|
There is a little bug in the autocomplete method the json_for_autocomplete doesn't catch the display_value. |
|
@geoffreyantoine what fixes did you make to elchbenny's fork in order to catch the display_value? Thanks! |
|
I've quickly did a fork for you: git@github.com:geoffreyantoine/rails3-jquery-autocomplete.git |
|
This is Perfect for the GEM. |
|
Why hasn't this been merged? It's very useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey, i come up with the ability to search based on different models and there attributes. I think it's very useful, at least in my case, but there are some changes in the signature of the autocomplete method, therefore it won't be backward compatible. i tried to change not that much, maybe not the most performant approach.
kind regards, benni