dynamodb: Remove value if Exists set to false in Expected block

See http://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_ExpectedAttributeValue.html
crowdmob · Feb 3, 2014 · e4727b6 · e4727b6
1 parent d8fd034
commit e4727b6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/dynamodb/item_test.go b/dynamodb/item_test.go
@@ -89,6 +89,7 @@ func (s *ItemSuite) TestConditionalPutUpdateDeleteItem(c *gocheck.C) {
 		// Put with condition failed
 		expected := []dynamodb.Attribute{
 			*dynamodb.NewStringAttribute("Attr1", "expectedAttr1Val").SetExists(true),
+			*dynamodb.NewStringAttribute("AttrNotExists", "").SetExists(false),
 		}
 		if ok, err := s.table.ConditionalPutItem("NewHashKeyVal", "", attrs, expected); ok {
 			c.Errorf("Expect condition does not meet.")

diff --git a/dynamodb/query_builder.go b/dynamodb/query_builder.go
@@ -195,8 +195,10 @@ func (q *Query) AddExpected(attributes []Attribute) {
 		if a.Exists != "" {
 			value["Exists"] = a.Exists
 		}
-		//UGH!!  (I miss the query operator)
-		value["Value"] = msi{a.Type: map[bool]interface{}{true: a.SetValues, false: a.Value}[a.SetType()]}
+		// If set Exists to false, we must remove Value
+		if value["Exists"] != "false" {
+			value["Value"] = msi{a.Type: map[bool]interface{}{true: a.SetValues, false: a.Value}[a.SetType()]}
+		}
 		expected[a.Name] = value
 	}
 	q.buffer["Expected"] = expected

diff --git a/dynamodb/query_builder_test.go b/dynamodb/query_builder_test.go
@@ -157,6 +157,7 @@ func (s *QueryBuilderSuite) TestAddExpectedQuery(c *gocheck.C) {
 
 	expected := []dynamodb.Attribute{
 		*dynamodb.NewStringAttribute("domain", "expectedTest").SetExists(true),
+		*dynamodb.NewStringAttribute("testKey", "").SetExists(false),
 	}
 	q.AddExpected(expected)
 
@@ -173,6 +174,9 @@ func (s *QueryBuilderSuite) TestAddExpectedQuery(c *gocheck.C) {
 				"Value": {
 					"S": "expectedTest"
 				}
+			},
+			"testKey": {
+				"Exists": "false"
 			}
 		},
 		"Key": {